Add testing/modifying instructions to README #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
Apr 19, 2024
hamishwillee
commented
Apr 19, 2024
README.md
Outdated
|
|
||
| Note that some examples use features that are still considered optional. | ||
| These are listed in the [supported proposals](https://github.com/WebAssembly/wabt/#supported-proposals) section on the WABT README.md, along with the flags used to invoke them. | ||
| For exmaple, to build WASM for the [multi-memory](https://github.com/mdn/webassembly-examples/blob/main/understanding-text-format/multi-memory.wat) example you will need to specify the `--enable-multi-memory` flag as shown: |
There was a problem hiding this comment.
@bsmth Note this folder structure - everything about understanding the text format is in one folder. But that doc contains heaps of sections, which really could be at their own level.
Anyway, I think in future we should require each example to be in its own sub folder, and at some point move all these too.
Merged
This is perfect, thanks a lot for adding! |
bsmth
reviewed
Apr 19, 2024
bsmth
reviewed
Apr 19, 2024
bsmth
approved these changes
Apr 19, 2024
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bsmth As discussed in #35 (comment)
This adds links to WABT, the docs on MDN, and to the table for supported features.